move environment vars to a configuration file - #269
Merged
AA-Turner merged 4 commits intoApr 11, 2025
Merged
AA-Turner merged 4 commits into
AA-Turner merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AA-Turner
reviewed
Apr 11, 2025
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
build_docs.py
Comment thread
build_docs.py
Outdated
Comment thread
build_docs.py
Outdated
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
AA-Turner
approved these changes
Apr 11, 2025
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I've pushed 78a70a7 (#269) to factor out the envvar config to a function.
A
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #266
This will allow us to write these files out to disk from python/psf-salt, and ensure they're picked up whenever/however build_docs.py is executed.