fix PathDistribution._normalized_name implementation - #377
Conversation
Sorry, something went wrong.
|
Thanks @benoit-pierre for this proposal. Unfortunately, I'm struggling a little bit with it, mainly because it fixes two unreported bugs in one commit. I'm also uneasy about the added complexity that "normalized names" is adding here (requiring fixtures with multiple return values). Would you mind writing up a bug report describing how you encountered this bug and how we might replicate it (and prove the fix)? I'm a little disappointed in the test suite right now. It seems the performance tests aren't running. Also, the linter didn't catch that name was shadowed and never used, which might have been an indicator that something was wrong. |
Sorry, something went wrong.
|
In #379, I've addressed the first issue. |
Sorry, something went wrong.
- apply PEP 503 normalization to the extracted names (e.g.: `zope..inter_face-4.2.dist-info` must yield the name `zope_inter_face`) `entry_points(…)` can yield the entry-points of a shadowed distribution. For example: with a version of `mypkg` in the system' site-packages directory when working from another development checkout of the same package (with a `mypkg.egg-info` directory mishandled by the first bug).
| assert version(pkg_name) == '1.0' | ||
| pkg_name, norm_pkg_name = self.pkg_with_dashes(self.site_dir) | ||
| dist = distribution(pkg_name) | ||
| assert dist._normalized_name == norm_pkg_name |
There was a problem hiding this comment.
Instead of testing the internal implementation details, I'd rather have a test that captures the failed expectation - namely that entry points of two packages whose file system names vary only by normalization won't deduplicate.
Sorry, something went wrong.
|
In #381, I've found I can capture the missed expectation by simply tweaking the test for test_entry_points_unique_packages to include the expected normalization. |
Sorry, something went wrong.
Sorry, something went wrong.
Both are necessary, or entry_points(…) can yield the entry-points of a shadowed distribution. For example: with a version of mypkg in the system' site-packages directory when working from another development checkout of the same package (with a mypgk.egg-info directory mishandled by the first bug).