Raise consistent ValueError for invalid EntryPoint.value - #518
Merged
jaraco merged 4 commits intoApr 27, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…t least 3 times (on construction and for module:attr access).
jaraco
force-pushed
the
bugfix/488-bad-ep-value
branch
from
f8a7887 to
9f8af01
Compare
April 27, 2025 14:10
Copy link
Copy Markdown
Member
Author
|
This change does introduce some performance degradation in the entry_points performance test: ===================================== perf ===================================== exercises.py:cached distribution: 0:00:00.000713 (+-1 day, 23:59:59.999988, -2%) exercises.py:discovery: 0:00:00.000719 (+0:00:00.000002, 0%) exercises.py:entry_points(): 0:00:00.010800 (+0:00:00.000700, 7%) exercises.py:entrypoint_regexp_perf: 0:00:00.000070 (+-1 day, 23:59:59.999999, -1%) exercises.py:uncached distribution: 0:00:00.001090 (+0:00:00, 0%) +.7 ms (7%) in this particular run. I've seen other numbers like 3% on my local machine. I saw a larger increase without the cached property. This seems to be an acceptable cost. |
Sorry, something went wrong.
jaraco
added a commit
that referenced
this pull request
Apr 27, 2025
Raise consistent ValueError for invalid EntryPoint.value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #488