bpo-47142: Refine Traversable. - #248
Merged
jaraco merged 3 commits intoApr 13, 2022
Merged
jaraco merged 3 commits into
jaraco merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ons on exceptions. Update joinpath to accept multiple arguments. Updated simple.ResourceContainer to match the protocol.
Copy link
Copy Markdown
Member
Author
|
@encukou, please take a look and let me know what you think. |
Sorry, something went wrong.
FFY00
approved these changes
Apr 11, 2022
FFY00
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This looks alright to me FWIW.
Sorry, something went wrong.
encukou
reviewed
Apr 13, 2022
Comment thread
importlib_resources/simple.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses concerns reported in bpo-47142.