readers: add MultiplexedPath.paths - #310
FFY00 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
@jaraco what do you think of this? |
Sorry, something went wrong.
jaraco
left a comment
There was a problem hiding this comment.
Seems reasonable to me. We should add some tests to ensure the use-case is covered. And should we include type annotations?
Sorry, something went wrong.
|
|
||
| @property | ||
| def paths(self): | ||
| return self._paths.copy() |
There was a problem hiding this comment.
If we type-annotate this property to be a non-mutable Sequence, and because self._paths is not mutated internally (also treated like a non-mutable Sequence), there's no need to make a copy. But I'm okay either way.
Sorry, something went wrong.
|
@FFY00 - do you still want to pursue this change? At this stage, I think type annotations would be preferred. |
Sorry, something went wrong.
Add a public `paths` attribute to every loader the editable finders hand out, listing the package's search locations (its `__path__` entries) so a package can find the CMake install tree at runtime. Add a matching read-only `paths` property to `_SkbuildMultiplexedPath`, mirroring python/importlib_resources#310. Addresses the second part of #1565. Assisted-by: ClaudeCode:claude-fable-5-1
* feat(editable): expose search paths on redirect loaders Add a public `paths` attribute to every loader the editable finders hand out, listing the package's search locations (its `__path__` entries) so a package can find the CMake install tree at runtime. Add a matching read-only `paths` property to `_SkbuildMultiplexedPath`, mirroring python/importlib_resources#310. Addresses the second part of #1565. Assisted-by: ClaudeCode:claude-fable-5-1 * Apply suggestion from @henryiii * docs: use pathlib over os.path in editable docs Assisted-by: opencode:NRP/deepseek-v4-flash
Fixes #309