A better error message from importlib.resources.files() when module spec is None - #331
Merged
jaraco merged 6 commits intoApr 12, 2026
Merged
jaraco merged 6 commits into
jaraco merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jaraco
reviewed
Apr 12, 2026
jaraco
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the contrib, and especially for the work on the original issue and PRs.
I have some comments, nothing blocking. For the sake of expediency, I'll address them so I can get this merged.
Sorry, something went wrong.
Comment thread
importlib_resources/tests/test_resource.py
Outdated
Comment thread
importlib_resources/tests/test_resource.py
Outdated
Comment thread
importlib_resources/_common.py
Outdated
Comment thread
importlib_resources/_common.py
Outdated
Comment thread
importlib_resources/_common.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from a PR on the CPython repository's importlib/resources.
The original PR is python/cpython#138531