Repository navigation
Make Python 2 support an extra - #10183
Merged
JukkaL merged 2 commits intoMar 8, 2021
Merged
JukkaL merged 2 commits into
JukkaL merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
added 2 commits
March 7, 2021 13:01
JukkaL
approved these changes
Mar 8, 2021
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks! Looks good. As users update to Python 3.8+, eventually most mypy users won't need to install typed-ast anymore.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I just noticed that this PR adds the python_version<'3.8' environment marker to install_requires, but not to mypy-requirements.txt. Is this on purpose? This is inconsistent with the psutil requirement which is also in extras_requires, but is not in mypy-requirements.txt. It is only in test-requirements.txt |
Sorry, something went wrong.
2 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10124