FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Stop running Python 3.5 in CI by hauntsaninja · Pull Request #10345 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Stop running Python 3.5 in CI - #10345

Merged
hauntsaninja merged 2 commits into
python:masterfrom
hauntsaninja:ci35
Apr 21, 2021
ConversationCommits (2)ChecksFiles changed
Merged

Stop running Python 3.5 in CI#10345
hauntsaninja merged 2 commits into
python:masterfrom
hauntsaninja:ci35

Conversation

hauntsaninja commented Apr 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Python 3.5 always fails in CI these days. So a) it's annoying and a bad contributor experience, b) we're effectively not testing against Python 3.5 anyway
Linking #9950

Stop running Python 3.5 in CI
d01804d 
Python 3.5 always fails in CI these days
Linking python#9950
emmatyping approved these changes Apr 20, 2021
View reviewed changes

emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I look forward to dropping support so we can use TypeVar without needing to guard it.

TH3CHARLie commented Apr 21, 2021

Copy link
Copy Markdown
Collaborator

Agreed. Should we keep the number of compiled suites by making 3.6 compiled?

hauntsaninja commented Apr 21, 2021

Copy link
Copy Markdown
Collaborator Author

You probably have a better sense of that than I do — how likely is it that 3.6 compiled will catch issues not caught by 3.7 compiled and 3.6?

hauntsaninja commented Apr 21, 2021

Copy link
Copy Markdown
Collaborator Author

I do seem to remember we had a CI false negative once because we didn't have a compiled >= 3.8 (due to some typeshed change to ast), so maybe we make Python 3.9 compiled

hauntsaninja requested a review from TH3CHARLie April 21, 2021 01:53
TH3CHARLie approved these changes Apr 21, 2021
View reviewed changes

TH3CHARLie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A compiled 3.9 LGTM!

hauntsaninja merged commit ba3578a into python:master Apr 21, 2021
hauntsaninja deleted the ci35 branch April 21, 2021 03:23

JukkaL commented Apr 21, 2021

Copy link
Copy Markdown
Collaborator

I think that we should run compiled tests on the earliest supported/working Python version and the latest, so it would be 3.6 and 3.9 after this change.

TH3CHARLie mentioned this pull request Apr 21, 2021
Merged
JukkaL pushed a commit that referenced this pull request Apr 21, 2021
Run compiled tests on earliest Python version (3.6) (#10349)
3bdef9f 
Related: #10345
freundTech mentioned this pull request May 12, 2021
Closed
19 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

emmatyping emmatyping approved these changes
+1 more reviewer
TH3CHARLie TH3CHARLie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL