Description

This PR is related to #708 and #5485, but fix them for dataclasses only. (Is there really an issue for regular classes?)

mypy currently handle dataclass callable fields as instance methods, as they are annotated at class level the same way a method would be. As a consequence, field node attribute is_initialized_in_class is True.

Here is an illustration of the current mypy behavior, comparing "regular" instance field annotation and dataclass one:

from dataclass import dataclasses
from typing import Callable

class A:
    def __init__():
        self.a: Callable[[int], int] = lambda i: i

@dataclass
class B:
    b: Callable[[int], int] = lambda i: i

A().a(0)  # is_initialized_in_class is False for variable `A().a` -> no error because A().a is instance variable access
B().b(0)  # is_initialized_in_class is True for variable `b().b`  -> error because B().b is a method access

By setting field node is_initialized_in_class to False, the field is then treated the same way it would be when declared with annotated assignment in __init__ method.

A first PR #10292 by @aecay concerning this issue was merged one month ago, but its implementation was more complex and did not fix the bug for frozen dataclasses, so I've reverted it. I hope there is no problem with that.

Test Plan

Add unit tests:

• mypy/test/testcheck.py::TypeCheckSuite::testDataclassCallableFieldAccess
• mypy/test/testcheck.py::TypeCheckSuite::testDataclassCallableFieldAssignment