FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable CI on Python 3.10 by 97littleleaf11 · Pull Request #11297 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Enable CI on Python 3.10 - #11297

Merged
JelleZijlstra merged 9 commits into
python:masterfrom
97littleleaf11:python3-10
Oct 11, 2021
ConversationCommits (9)ChecksFiles changed
Merged

Enable CI on Python 3.10#11297
JelleZijlstra merged 9 commits into
python:masterfrom
97littleleaf11:python3-10

Conversation

97littleleaf11 commented Oct 8, 2021

Copy link
Copy Markdown
Collaborator

Description

Closes #11294

Test Plan

Check the tests still failed.

pranavrajpal reviewed Oct 8, 2021
View reviewed changes
Comment thread .github/workflows/test.yml Outdated
Comment on lines +107 to +108
if: ${{ matrix.python == '3.10' }}
run: pip install --upgrade virtualenv==20.4.7

pranavrajpal Oct 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it might be better to just use virtualenv 20 always instead of just on python 3.10. #10855 seems to have added support for using virtualenv 20, so I think that PR just forgot to update the CI to use virtualenv 20.

TH3CHARLie commented Oct 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

You may need to fix the build by fixing mypyc imports first

97littleleaf11 commented Oct 8, 2021

Copy link
Copy Markdown
Collaborator Author

We could probably merge #11017 first

JelleZijlstra commented Oct 8, 2021

Copy link
Copy Markdown
Member

We could probably merge #11017 first

Done!

TH3CHARLie mentioned this pull request Oct 10, 2021
Closed

hauntsaninja commented Oct 10, 2021

Copy link
Copy Markdown
Collaborator

Hooray!

hauntsaninja commented Oct 10, 2021

Copy link
Copy Markdown
Collaborator

Can we merge master for #11306

pranavrajpal reviewed Oct 10, 2021
View reviewed changes
Comment thread test-data/packages/typedpkg-stubs/setup.py
"""

from distutils.core import setup
from setuptools import setup

pranavrajpal Oct 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the usage of distutils that is causing a DeprecationWarning is in the setup.py mypyc generates to build C extensions:

mypy/scripts/mypyc

Lines 21 to 28 in 8cba3bc

setup_format = """\
from distutils.core import setup
from mypyc.build import mypycify
setup(name='mypyc_output',
ext_modules=mypycify({}, opt_level="{}"),
)
"""

I'm not really sure what this file's for but I don't think this is what's causing the CI failure.

97littleleaf11 Oct 10, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yeah, I'm looking at these. However I just wondering whether should I modify the test-data/packages/typedpkg-stubs/setup.py

JelleZijlstra Oct 10, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's a sample package used for unit tests. We should probably update it too, but it should only affect a few unit tests.

97littleleaf11 commented Oct 11, 2021

Copy link
Copy Markdown
Collaborator Author

Passes all tests now

TH3CHARLie approved these changes Oct 11, 2021
View reviewed changes

TH3CHARLie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

great job on making Python 3.10 working in CI

JelleZijlstra merged commit 332b712 into python:master Oct 11, 2021
97littleleaf11 deleted the python3-10 branch October 11, 2021 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra Awaiting requested review from JelleZijlstra
2 more reviewers
pranavrajpal pranavrajpal left review comments
TH3CHARLie TH3CHARLie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable CI to use Python 3.10

5 participants

Back | FazBrowse Home | New Git URL