Repository navigation
Support PEP 613 - #11305
Merged
hauntsaninja merged 1 commit intoOct 12, 2021
Merged
Support PEP 613#11305hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Resolves python#9404
Copy link
Copy Markdown
Contributor
|
Thank you for working on this. I would really love to be able to use type aliases in typeshed. |
Sorry, something went wrong.
Comment thread
test-data/unit/check-type-aliases.test
| from typing_extensions import TypeAlias | ||
|
|
||
| x: TypeAlias = list(int) # E: Invalid type alias: expression is not a valid type \ | ||
| # E: Too many arguments for "list" |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The second error is weird but seems unrelated to your changes.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Yeah, I assumed it was just a fixtures thing
Sorry, something went wrong.
JelleZijlstra
approved these changes
Oct 10, 2021
sobolevn
approved these changes
Oct 12, 2021
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Awesome, so excited about this feature! 👍
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thank you! This is awesome. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9404