| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self) -> None: pass g = f C().g() ``` However, #10548 broke this in a subtle way (no error on definition), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pydantic (https://github.com/samuelcolvin/pydantic.git)
- pydantic/validators.py:503: error: Unused "type: ignore" comment
sphinx (https://github.com/sphinx-doc/sphinx.git)
- sphinx/domains/std.py: note: In member "handle_signature" of class "GenericObject":
- sphinx/domains/std.py:58:20: error: Too few arguments
- sphinx/domains/std.py:58:36: error: Argument 1 has incompatible type "BuildEnvironment"; expected "GenericObject"
- sphinx/domains/std.py:58:46: error: Argument 2 has incompatible type "str"; expected "BuildEnvironment"
- sphinx/domains/std.py:58:51: error: Argument 3 has incompatible type "desc_signature"; expected "str"
graphql-core (https://github.com/graphql-python/graphql-core.git)
- src/graphql/execution/execute.py:216: error: Unused "type: ignore" comment
- src/graphql/execution/execute.py:217: error: Unused "type: ignore" comment
- src/graphql/execution/execute.py:807: error: Unused "type: ignore" comment
|
Sorry, something went wrong.
This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self, ...) -> None: pass g = f C().g(...) # Now sometimes generates an error ``` However, #10548 broke this in a subtle way (no error on definition, it sometimes generates an error on call), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
…n#11571) This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self, ...) -> None: pass g = f C().g(...) # Now sometimes generates an error ``` However, python#10548 broke this in a subtle way (no error on definition, it sometimes generates an error on call), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
| Back | FazBrowse Home | New Git URL |
This reverts commit 6ab0efc.
Reverting the change since it causes a significant backward
compatibility break. Code like this previously worked as expected:
class C: def f(self) -> None: pass g = f C().g() # Sometimes generates an errorHowever, #10548 broke this in a subtle way (no error on definition,
it sometimes generates an error on call), and instead required the
introduction of a ClassVar annotation for g, which is non-intuitive
and error-prone. For example, some typeshed stubs use method
aliases such as the above (e.g. stubs for logging), and the change
broke those stubs. It's also arguably inconsistent, since normally
ClassVar annotations are optional.
Any fix to the original issue should avoid breaking method aliases
such as the above. Hopefully the fix can be adjusted suitably.
The PR may have broken incremental mode somehow as well -- cached
and uncached runs sometimes produce different results. The root
cause is still unclear, however.