FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "stubtest pos-only differences in dunders (#12184)" by hauntsaninja · Pull Request #12293 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Revert "stubtest pos-only differences in dunders (#12184)" - #12293

Merged
hauntsaninja merged 1 commit into
python:masterfrom
hauntsaninja:stubts
Mar 5, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Revert "stubtest pos-only differences in dunders (#12184)"#12293
hauntsaninja merged 1 commit into
python:masterfrom
hauntsaninja:stubts

Conversation

hauntsaninja commented Mar 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This reverts commit 777885f.

To help with python/typeshed#7441 and reduce risk of stubtest issues interfering with a mypy release. The extra type correctness here is really minimal.

hauntsaninja mentioned this pull request Mar 5, 2022
Closed

github-actions Bot commented Mar 5, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JelleZijlstra approved these changes Mar 5, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Always glad when mypy-primer confirms that changing stubtest doesn't affect typechecking output.

Though maybe we need a stubtest-primer that tells us stubtest's output on all of typeshed's third-party stubs.

hauntsaninja merged commit b3752a6 into python:master Mar 5, 2022
hauntsaninja deleted the stubts branch March 5, 2022 01:50
AlexWaygood reviewed Mar 5, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I agree this was the way to go :)

AlexWaygood commented Mar 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

[M]aybe we need a stubtest-primer that tells us stubtest's output on all of typeshed's third-party stubs.

Yes, I think this would be very helpful. Something similar to the "Daily test" job in the typeshed CI, that's run on every stubtest PR, would be amazing. (Edit: it would obviously have to be done in a non-blocking way, like mypy_primer.)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
+1 more reviewer
AlexWaygood AlexWaygood left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL