Repository navigation
Replace hard crash with typecheck error when subclass method has the same name as type alias - #13015
Merged
JukkaL merged 1 commit intoJun 24, 2022
Merged
JukkaL merged 1 commit into
JukkaL merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…same name as type alias work on python#5425
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks, can we use UninhabitedType instead of NoneType?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Since we used NoneType previously in the same function, this seem fine to me. We don't actually seem to perform any interesting type operations on the type, unless it's a function type. |
Sorry, something went wrong.
JukkaL
approved these changes
Jun 24, 2022
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks! Looks good to me.
Sorry, something went wrong.
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
…same name as type alias (python#13015) Work on python#5425 Co-authored-by: Wesley Wright <wesleyw@dropbox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5425.
Typechecking for method overrides ended in an assert False for any AST nodes other than FuncDef, OverloadedFuncDef, Decorator, and Var. This PR replaces this with a typecheck error for any unrecognized AST nodes instead.
Test Plan
Added a new test case to check-classes.test covering the original bug report from the example, as well as some extra cases that Jukka mentioned in the comments.