Repository navigation
More cases showing errors disappearing from dmypy reruns - #15049
Closed
meshy wants to merge 1 commit into
Closed
meshy wants to merge 1 commit into
meshy wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This shows two cases where errors disappear from the second run of dmypy. The first shows a way that "unused type ignore" errors can disappear. The case is a little complicated, but I can't yet work out how to make it smaller. The second case shows how "module X has not attribute Y" errors can disappear.
This was referenced Apr 27, 2023
Closed
Copy link
Copy Markdown
Contributor
Author
|
Closing this because I have merged these tests into #15043 and fixed them. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test for two cases where errors disappear from the second run of dmypy.
The first shows a way that "unused type ignore" errors can disappear. The case is a little complicated, but I haven't yet worked out how to make it smaller.
The second case shows how "module X has not attribute Y" errors can disappear.
I think this shows another instance of #9655, but my instinct is that the fix for this will differ from the fix for #15043.
I have added this as a proof of the issue, and plan to evolve this PR as I investigate the cause.