Repository navigation
Add explanation if argument type is incompatible because of a "numbers" type - #15137
Merged
hauntsaninja merged 5 commits intoApr 26, 2023
Merged
hauntsaninja merged 5 commits into
hauntsaninja merged 5 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
AlexWaygood
reviewed
Apr 25, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Brilliant that we're improving usability here!
Sorry, something went wrong.
This comment has been minimized.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Apr 25, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
yay!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack) got 1.10 slower (67.7s -> 74.6s)
|
Sorry, something went wrong.
hauntsaninja
approved these changes
Apr 26, 2023
hauntsaninja
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This looks great, thank you!
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types from numbers aren't really supported in any useful way. Make it more explicit, since this is surprising.
Work on #3186.