Repository navigation
Improve error messages for super checks and add more tests - #16393
Merged
sobolevn merged 4 commits intoNov 3, 2023
Merged
sobolevn merged 4 commits into
sobolevn merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
Comment thread
test-data/unit/check-super.test
Outdated
hauntsaninja
approved these changes
Nov 3, 2023
AlexWaygood
reviewed
Nov 3, 2023
Comment thread
test-data/unit/check-super.test
Outdated
| @staticmethod | ||
| def st() -> int: | ||
| reveal_type(super(B, B).st()) # N: Revealed type is "builtins.int" | ||
| super().st() # E: "super" requires one or more positional arguments in enclosing function |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Here again, it's specifically the zero-argument form of super() that we're complaining about (the reveal_type() call in the line immediately above this one works fine for the two-argument form of super()). So I'd keep the () here as well, personally
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
And it should be "one or two" not "one or more" 👍
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all messages use the same "super" formatting, it used to be a bit different.