Repository navigation
Do not allow TypedDict classes with extra keywords - #16438
Merged
JelleZijlstra merged 3 commits intoNov 18, 2023
Merged
JelleZijlstra merged 3 commits into
JelleZijlstra merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AlexWaygood
approved these changes
Nov 9, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This comment has been minimized.
Comment thread
mypy/semanal.py
Outdated
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Member
Author
|
I realized that I want to reuse existing messages: » mypy -c 'class A(a=1, b=2): ...' <string>:1: error: Unexpected keyword argument "a" for "__init_subclass__" of "object" [call-arg] <string>:1: error: Unexpected keyword argument "b" for "__init_subclass__" of "object" [call-arg] Found 2 errors in 1 file (checked 1 source file) |
Sorry, something went wrong.
Comment thread
test-data/unit/check-typeddict.test
Outdated
sobolevn
force-pushed
the
issue-16432
branch
from
f8bcebb to
871d204
Compare
November 17, 2023 16:13
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that sometimes metaclass= can still be used in real code, when people write compatibility layers with other metaclasses. I think that I've seen this a couple of times, but I cannot remember where and why.
In this case, this error can be precisely silenced.