FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Stubtest: give more helpful errors if a function is missing from the stub by AlexWaygood · Pull Request #16517 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Stubtest: give more helpful errors if a function is missing from the stub - #16517

Merged
hauntsaninja merged 2 commits into
python:masterfrom
AlexWaygood:stubtest-missing-functions
Nov 18, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Stubtest: give more helpful errors if a function is missing from the stub#16517
hauntsaninja merged 2 commits into
python:masterfrom
AlexWaygood:stubtest-missing-functions

Conversation

AlexWaygood commented Nov 18, 2023

Copy link
Copy Markdown
Member

Currently, if a function exists at runtime but is missing from the stub, stubtest will emit an error message like this:

error: shelve.Shelf.__del__ is not present in stub
Stub: in file stdlib\shelve.pyi
MISSING
Runtime: in file C:\Users\alexw\AppData\Local\Programs\Python\Python312\Lib\shelve.py:157
<function Shelf.__del__ at 0x0000024822FD7060>

error: subprocess.Popen.__del__ is not present in stub
Stub: in file stdlib\subprocess.pyi
MISSING
Runtime: in file C:\Users\alexw\AppData\Local\Programs\Python\Python312\Lib\subprocess.py:1120
<function Popen.__del__ at 0x00000248215D3D80>

This isn't particularly helpful: it doesn't tell you anything about the function at runtime, just that there is one. With this PR, stubtest's error messages change to this, which is much more helpful:

error: shelve.Shelf.__del__ is not present in stub
Stub: in file stdlib\shelve.pyi
MISSING
Runtime: in file C:\Users\alexw\AppData\Local\Programs\Python\Python312\Lib\shelve.py:157
def (self)

error: subprocess.Popen.__del__ is not present in stub
Stub: in file stdlib\subprocess.pyi
MISSING
Runtime: in file C:\Users\alexw\AppData\Local\Programs\Python\Python312\Lib\subprocess.py:1120
def (self, _maxsize=9223372036854775807, _warn=<built-in function warn>)

hauntsaninja approved these changes Nov 18, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice, thank you!

hauntsaninja merged commit 6cbdab8 into python:master Nov 18, 2023
AlexWaygood deleted the stubtest-missing-functions branch November 18, 2023 20:23
QuLogic mentioned this pull request Apr 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL