Repository navigation
Allow type ignores of PEP 695 constructs - #16608
Merged
JukkaL merged 6 commits intoDec 7, 2023
Merged
JukkaL merged 6 commits into
JukkaL merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This is basically a pre-existing bug and affects other errors that ASTConverter might raise, like merging overloads. It could vaguely be nice to move all the set_file_ignored_lines into fastparse, instead of BuildManager.parse_file. Could also clean up the ignore_errors logic a little bit more. Fixes python#16607
This comment has been minimized.
This comment has been minimized.
hauntsaninja
marked this pull request as draft
December 4, 2023 07:24
for more information, see https://pre-commit.ci
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
hauntsaninja
marked this pull request as ready for review
December 4, 2023 08:03
Closed
JukkaL
approved these changes
Dec 7, 2023
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks, looks good to me!
Sorry, something went wrong.
wesleywright
pushed a commit
that referenced
this pull request
Dec 7, 2023
This is basically a pre-existing bug and affects other errors that ASTConverter might raise, like merging overloads. It could vaguely be nice to move all the set_file_ignored_lines into fastparse, instead of BuildManager.parse_file. Could also clean up the ignore_errors logic a little bit more. Fixes #16607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a pre-existing bug and affects other errors that ASTConverter might raise, like merging overloads.
It could vaguely be nice to move all the set_file_ignored_lines into fastparse, instead of BuildManager.parse_file. Could also clean up the ignore_errors logic a little bit more.
Fixes #16607