Repository navigation
Fix disallow-any errors for Instance types (PEP 696) - #16832
Merged
JelleZijlstra merged 2 commits intoJan 31, 2024
Merged
JelleZijlstra merged 2 commits into
JelleZijlstra merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment has been minimized.
cdce8p
force-pushed
the
TypeVar-07-fix-disallow-any
branch
from
2b21ed3 to
308e87a
Compare
January 31, 2024 16:12
Comment thread
test-data/unit/check-typevar-defaults.test
Outdated
|
|
||
| def func_c4( | ||
| a: ClassC4, | ||
| a: ClassC4, # E: Missing type parameters for generic type "ClassC4[()]" |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why the [()] part?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Adjusted the type formatting to better handle this case. It was just checking if the instance has a TypeVarTuple and assumed that it's the only TypeVar -> thus printing () for an empty tuple.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to TypeAlias types Missing type parameters for generic type should not be emitted if too many arguments are given. There is a separate error message for that.
Ref: #14851