Repository navigation
Remove --python-version 3.7 references from tests - #16848
Merged
JelleZijlstra merged 6 commits intoFeb 1, 2024
Merged
JelleZijlstra merged 6 commits into
JelleZijlstra merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cdce8p
marked this pull request as draft
February 1, 2024 14:32
This comment has been minimized.
cdce8p
marked this pull request as ready for review
February 1, 2024 15:08
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
test-data/unit/check-callable.test
Outdated
Comment thread
test-data/unit/check-errorcodes.test
Outdated
Comment thread
test-data/unit/check-errorcodes.test
Outdated
Comment thread
test-data/unit/check-generic-alias.test
Outdated
Comment thread
test-data/unit/check-generic-alias.test
Outdated
Comment thread
test-data/unit/check-newsemanal.test
Outdated
Comment thread
test-data/unit/check-union-or-syntax.test
Outdated
Comment thread
test-data/unit/pythoneval.test
Outdated
|
|
||
| [case testTypeAliasWithNewStyleUnionInStub] | ||
| # flags: --python-version 3.7 | ||
| # flags: --python-version 3.8 |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| # flags: --python-version 3.8 |
Not clear why this needs a version restriction
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Reverted the changes to pythoneval.test entirely to prevent merge conflicts with #16844.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove --python-version 3.7 from tests if not necessary anymore or use 3.8 where it makes sense instead.