Repository navigation
FIx stubtest's tests to work with the latest version of typing_extensions - #16928
Merged
JelleZijlstra merged 1 commit intoFeb 18, 2024
Merged
JelleZijlstra merged 1 commit into
JelleZijlstra merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…sions` Stubtest's tests will start failing when `typing_extensions==4.10.0` comes out, due to some new `ClassVar`s on `typing_extensions.TypedDict`. This PR fixes that. Fixes python/typing_extensions#339. Note: there's no need to cherry-pick this to the `release-1.9.0` branch, since the daily workflow `typing_extensions` uses runs mypy's tests using the mypy `master` branch.
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
hamdanal
pushed a commit
to hamdanal/mypy
that referenced
this pull request
Feb 20, 2024
…sions` (python#16928) Stubtest's tests will start failing when `typing_extensions==4.10.0` comes out, due to some new `ClassVar`s on `typing_extensions.TypedDict`. This PR fixes that. Fixes python/typing_extensions#339. Note: there's no need to cherry-pick this to the `release-1.9.0` branch, since the daily workflow `typing_extensions` uses runs mypy's tests using the mypy `master` branch.
Copy link
Copy Markdown
Member
Author
I guess this didn't hold up very well, huh (#17005) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stubtest's tests will start failing when typing_extensions==4.10.0 comes out, due to some new ClassVars on typing_extensions.TypedDict. This PR fixes that.
Fixes python/typing_extensions#339. Note: there's no need to cherry-pick this to the release-1.9.0 branch, since the daily workflow typing_extensions uses runs mypy's tests using the mypy master branch.