Repository navigation
Fix type narrowing for types.EllipsisType - #17003
Merged
hauntsaninja merged 1 commit intoMar 10, 2024
Merged
hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I know it seems silly but perhaps we should add a test to prevent regressions on this 😅 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Yeah, I thought about it, but you need one of the expensive tests that runs against full typeshed (and also behaviour here is version dependent because types.EllipsisType is a 3.10 thing) |
Sorry, something went wrong.
emmatyping
approved these changes
Mar 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17002