Repository navigation
Filter overload items based on self type during type inference - #17873
Merged
JukkaL merged 11 commits intoOct 3, 2024
Merged
JukkaL merged 11 commits into
JukkaL merged 11 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
ilevkivskyi
approved these changes
Oct 3, 2024
ilevkivskyi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yeah, looks hacky, but OK as a quick fix.
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
+ discord/ext/commands/help.py:668: error: Argument "key" to "sort" of "list" has incompatible type "Callable[[Command[Any, [VarArg(Any), KwArg(Any)], Any]], Any] | None"; expected "Callable[[Command[Any, [VarArg(Any), KwArg(Any)], Any]], SupportsDunderLT[Any] | SupportsDunderGT[Any]]" [arg-type]
scipy (https://github.com/scipy/scipy)
- scipy/_lib/unuran/get_and_clean_unuran.py:55: error: Cannot infer type argument 1 of "copyfileobj" [misc]
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
The new error in discord.py seems correct. We are now filtering the overloads of list.sort as expected. |
Sorry, something went wrong.
This was referenced Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type argument inference for overloaded functions with explicit self types. Filter out the overload items based on the declared and actual types of self. The implementation is best effort and does the filtering only in simple cases, to reduce the risk of regressions (primarily performance, but I worry also about infinite recursion). I added a fast path for the typical case, since without it the filtering was quite expensive.
Note that the overload item filtering already worked in many contexts. This only improves it in specific contexts -- at least when inferring generic protocol compatibility.
This is a more localized (and thus lower-risk) fix compared to #14975 (thanks @tyralla!). #14975 might still be a good idea, but I'm not comfortable merging it now, and I want a quick fix to unblock the mypy 1.12 release.
Fixes #15031. Fixes #17863.
Co-authored by @tyralla.