Repository navigation
Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute - #18402
Merged
hauntsaninja merged 8 commits intoJun 1, 2025
Merged
Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute#18402hauntsaninja merged 8 commits into
hauntsaninja merged 8 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
hauntsaninja
marked this pull request as draft
January 1, 2025 22:01
hauntsaninja
marked this pull request as ready for review
May 25, 2025 22:51
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Author
|
Hmm, false positive is because Collection actually has a long MRO. But the length of a protocol MRO doesn't really mean anything. So I will just change is_better |
Sorry, something went wrong.
This comment has been minimized.
This was referenced May 26, 2025
Copy link
Copy Markdown
Collaborator
Author
|
cc @JukkaL one more nondeterminism PR! |
Sorry, something went wrong.
JukkaL
approved these changes
May 28, 2025
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks! Looks good overall, though the logic is getting pretty hard to follow. Left some comments about tests.
Sorry, something went wrong.
Comment thread
test-data/unit/check-inference.test
Comment thread
test-data/unit/check-inference.test
Comment thread
test-data/unit/check-protocols.test
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: nox (https://github.com/wntrblm/nox): 1.46x slower (24.6s -> 35.9s in single noisy sample)
typeshed-stats (https://github.com/AlexWaygood/typeshed-stats): 1.57x slower (60.7s -> 95.0s in single noisy sample)
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16979 (bzoracler case only, OP case fixed by #19147)
See #16979 (comment)