Repository navigation
Fix missing error context for unpacking assignment involving star expression - #19258
Merged
hauntsaninja merged 1 commit intoJun 10, 2025
Merged
hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
A5rocks
reviewed
Jun 9, 2025
Comment thread
mypy/checker.py
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
A5rocks
approved these changes
Jun 9, 2025
sterliakov
approved these changes
Jun 9, 2025
Copy link
Copy Markdown
|
Nice work. I just tested it. Note that it also restores the possiblty to use # type: ignore comment. a: int
b: list[str]
(a,) = (*b,) # type: ignore[assignment]
(a,) = [*b] # type: ignore[assignment]Before (v1.16.0)tmp.py: error: Incompatible types in assignment (expression has type "str", variable has type "int") [assignment] Found 1 error in 1 file (checked 1 source file) AfterSuccess: no issues found in 1 source file |
Sorry, something went wrong.
hauntsaninja
approved these changes
Jun 10, 2025
hauntsaninja
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Nice, thank you!
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19257
Given:
Before:
After:
main.py:3: error: Incompatible types in assignment (expression has type "str", variable has type "int") [assignment] (a,) = (*b,) ^ main.py:4: error: Incompatible types in assignment (expression has type "str", variable has type "int") [assignment] (a,) = [*b] ^ Found 2 errors in 1 file (checked 1 source file)