FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

More shards for `mypy-primer` by randolf-scholz · Pull Request #19405 · python/mypy · GitHub

Repository navigation

More shards for mypy-primer - #19405

Merged
JukkaL merged 2 commits into
python:masterfrom
randolf-scholz:more_shards_mypy_primer
Jul 9, 2025
Merged

JukkaL merged 2 commits into
python:masterfrom
randolf-scholz:more_shards_mypy_primer

Conversation

Copy link
Copy Markdown
Contributor

Increases the number of shards by 1 which helps with #19403.

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

JukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok, let's see if this helps.

JukkaL merged commit 40277a1 into python:master Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Oh actually, we did merge hauntsaninja/mypy_primer#190 upstream, which almost doubles the weight of colour and it appears it now occupies a whole shard by itself, so this won't do much anymore.

Here's a sample run: https://github.com/python/mypy/actions/runs/16173327386/job/45652190197?pr=19399

JukkaL commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

I wonder if we should revert this then?

Copy link
Copy Markdown
Collaborator

Yes, I think so - the zeroth shard dedicated to colour still dominates the total execution time, other shards complete much earlier. However, if #19408 gets through, this will be good again - halving colour check time will make all six shards ~ equal.

JukkaL commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

Ok, I'll try to review #19408 soon -- if it can be merged soon, we don't need to revert this at all then.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL