Repository navigation
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Specialize iteration for the concrete types `list` and `tuple`, since this is faster than iterating over an abstract iterable in compiled code. Duplicate some very hot code in the hopes further improving preformance slightly, through inlining and possibly also better branch prediction. This is a part of a set of micro-optimizations that improve self check performance by ~5.5%.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
ilevkivskyi
approved these changes
Jul 17, 2025
ilevkivskyi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Interesting, I would never guess this is a hot code path.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specialize iteration for the concrete types list and tuple, since this is faster than iterating over an abstract iterable in compiled code. Also avoid constructing many temporary lists.
Duplicate some very hot code in the hopes further improving performance slightly, through inlining and possibly also better branch prediction.
The approach is similar to what I used in #19459.
This is a part of a set of micro-optimizations that improve self check performance by ~5.5%.