Repository navigation
[mypyc] [WIP] feat(test): failing test case using builtin weakref.proxy - #19571
Closed
BobTheBuidler wants to merge 3 commits into
Closed
BobTheBuidler wants to merge 3 commits into
BobTheBuidler wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Turns out, this behavior is explained by a discrepancy between mypyc semantics and python semantics. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #19217 I ran into a failing test that I couldn't explain for the life of me. It didn't seem to have anything to do with my code changes. So I made this new branch that includes my new tests from that branch without the actual changes to mypyc code, and the tests still fail using the builtin weakref.proxy implementation.
For now, this PR only exists to make the failing tests conveniently sharable.