Repository navigation
Better support for SomeEnum.item == some_literal - #19594
Draft
sterliakov wants to merge 13 commits into
Draft
sterliakov wants to merge 13 commits into
sterliakov wants to merge 13 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment has been minimized.
A5rocks
suggested changes
Aug 5, 2025
A5rocks
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I was a bit confused about this in the original issue too
Sorry, something went wrong.
Comment thread
test-data/unit/check-enum.test
Outdated
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sterliakov
marked this pull request as ready for review
August 28, 2025 13:51
A5rocks
approved these changes
Aug 28, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Draft until I can address #20142 (comment) |
Sorry, something went wrong.
sterliakov
marked this pull request as draft
October 30, 2025 13:09
Copy link
Copy Markdown
Collaborator
|
Probably this has to be recreated to work with new narrowing... and half of the listed issues are closed now! (not really sure though, I completely forgot what this PR does :/) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19576.
Fixes #16327.
Fixes #17162.
Fixes #19753.
This needs more feedback: is the logic I propose reasonable? Do we want to be stricter and reject such comparisons altogether? Or maybe only reject them if values are incompatible?