Repository navigation
[mypyc] feat: ForFilter generator helper for builtins.filter - #19643
BobTheBuidler wants to merge 51 commits into
Conversation
Sorry, something went wrong.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Just realized I can extend this class to make it work for both builtins.filter and itertools.filterfalse with only 4 more LOC I wouldn't think to make a primitive for iteration solely over itertools.filterfalse, but considering it would share the same object and only require one more boolean attribute, I think it makes sense to support here. What do you guys think? |
Sorry, something went wrong.
for more information, see https://pre-commit.ci
This reverts commit c9680dc.
for more information, see https://pre-commit.ci
|
I went ahead and implemented the above on a new branch here, we can merge it into this branch if we decide its worth special casing. I'd say it probably is, considering the code change is quite minimal change once we already have ForFilter defined. |
Sorry, something went wrong.
|
I don't yet think the failing docs workflow is related to this PR, given that I only added a single bullet point to the native_operations.rst, though can't say for sure |
Sorry, something went wrong.
|
Some tests are failing. Do yo need help with the failures? |
Sorry, something went wrong.
|
Yeah I could definitely use some help with this one, I'm not sure which recent change(s) caused this err nor what to do about it Is this just another typeshed thing? I also have one open question above from one of your review comments. I just tagged you in it to notify. |
Sorry, something went wrong.
oh, whoops! Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
|
Okay I've committed that change, once the tests finish the remaining IR errors should be related to the builder.accept comments above and will go away once we resolve that |
Sorry, something went wrong.
| # from mypyc.irbuild.expression import transform_call_expr | ||
|
|
||
| # result = transform_call_expr(builder, fake_call_expr) | ||
| result = builder.accept(fake_call_expr) |
There was a problem hiding this comment.
I'm reverting this to its original state so the tests can turn green again. You'll see this as part of your review anyway.
Sorry, something went wrong.
This PR adds a ForFilter helper class for for loops over builtins.filter which allows mypyc to maintain control of the function calling, so it can call native functions and use primitive ops, and to optimize filter's boolean check based on func's return value type