Repository navigation
Check functions without annotations in mypyc tests - #19792
Merged
hauntsaninja merged 3 commits intoJan 18, 2026
Merged
hauntsaninja merged 3 commits into
hauntsaninja merged 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
brianschubert
commented
Sep 4, 2025
Comment thread
mypyc/test-data/run-weakref.test
Outdated
Closed
JukkaL
reviewed
Sep 5, 2025
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This is a good idea, though I'm hoping to annotate all test cases eventually (but this will take some work).
Sorry, something went wrong.
Comment thread
mypyc/test-data/run-singledispatch.test
Outdated
Comment thread
mypyc/test-data/run-classes.test
Outdated
Copy link
Copy Markdown
Collaborator
|
I merged a change to mypyc weakref primitives and tests. Can you merge one more conflict? Then this should be good to go. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c.f. #19217 (comment)
Disallowing functions without annotations (where not relevant to the tests) is probably a good idea, but this creates a large number of failures which would take some time to go through (many due to common issues, like untyped functions in the fixtures).
As a smaller step in the right direction, this sets check_untyped_defs = True for the run-* tests so that we at least check functions without annotations.