FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Kill Void in strict optional mode by ddfisher · Pull Request #1980 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Kill Void in strict optional mode - #1980

Merged
gvanrossum merged 1 commit into
masterfrom
void-also-gazes-into-you
Aug 3, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Kill Void in strict optional mode#1980
gvanrossum merged 1 commit into
masterfrom
void-also-gazes-into-you

Conversation

ddfisher commented Aug 3, 2016

Copy link
Copy Markdown
Collaborator

This preserves the vast majority of "Function does not return a value" warnings provided by Void.

Fixes #1975.
Fixes #1956.

ddfisher commented Aug 3, 2016

Copy link
Copy Markdown
Collaborator Author

It looks like this fixes roughly 30 of the mypy --strict-optional mypy errors.

ddfisher force-pushed the void-also-gazes-into-you branch from 21e925a to 04badd7 Compare August 3, 2016 01:28
gvanrossum merged commit ef0382e into master Aug 3, 2016

gvanrossum commented Aug 3, 2016

Copy link
Copy Markdown
Member

I'm feeling lucky today. :-)

ddfisher mentioned this pull request Aug 3, 2016
Merged
ddfisher deleted the void-also-gazes-into-you branch August 3, 2016 22:32
This was referenced Aug 4, 2016
Closed
Closed

rwbarton commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

Yay!

I'm not super enthused about having "mostly equal" types NoneTyp(is_ret_type=False) and NoneTyp(is_ret_type=True), since it becomes unclear in which contexts the difference matters. For example what is join_types(NoneTyp(is_ret_type=False), NoneTyp(is_ret_type=True))? Or does it not really matter? I wonder if you can achieve the same result with purely syntactic checks.

Still very happy to see the Void/NoneTyp distinction gone though.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL