Repository navigation
fix: something Shantanu found - #19859
Merged
ilevkivskyi merged 2 commits intoSep 25, 2025
Merged
ilevkivskyi merged 2 commits into
ilevkivskyi merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
to be honest I have no idea what this code does, but I know we need to fix it
This comment has been minimized.
Copy link
Copy Markdown
Contributor
Author
|
Are these 2 changes proper? =================================== FAILURES ===================================
_____________________________ testFinalValuesOnVar _____________________________
[gw0] linux -- Python 3.12.11 /home/runner/work/mypy/mypy/.tox/py/bin/python
data: /home/runner/work/mypy/mypy/test-data/unit/semanal-basic.test:489:
Failed: Invalid semantic analyzer output (/home/runner/work/mypy/mypy/test-data/unit/semanal-basic.test, line 489)
----------------------------- Captured stderr call -----------------------------
Expected:
MypyFile:1(
ImportFrom:1(typing, [Final, Any])
FuncDef:3(
...
NameExpr(True [builtins.True])
Literal[True]?)
AssignmentStmt:8(
NameExpr(n* [__main__.n] = None) (diff)
CallExpr:8(
NameExpr(func [__main__.func])
Args())))
Actual:
MypyFile:1(
ImportFrom:1(typing, [Final, Any])
FuncDef:3(
...
NameExpr(True [builtins.True])
Literal[True]?)
AssignmentStmt:8(
NameExpr(n* [__main__.n]) (diff)
CallExpr:8(
NameExpr(func [__main__.func])
Args())))
Alignment of first line difference:
E: NameExpr(n* [__main__.n] = None)
A: NameExpr(n* [__main__.n])
^
Update the test output using --update-data (implies -n0; you can additionally use the -k selector to update only specific tests)
_____________________________ testFinalValuesOnVar _____________________________
[gw3] linux -- Python 3.12.11 /home/runner/work/mypy/mypy/.tox/py/bin/python
data: /home/runner/work/mypy/mypy/test-data/unit/semanal-basic.test:489:
Failed: Invalid semantic analyzer output (/home/runner/work/mypy/mypy/test-data/unit/semanal-basic.test, line 489)
----------------------------- Captured stderr call -----------------------------
Expected:
MypyFile:1(
ImportFrom:1(typing, [Final, Any])
FuncDef:3(
...
NameExpr(True [builtins.True])
Literal[True]?)
AssignmentStmt:8(
NameExpr(n* [__main__.n] = None) (diff)
CallExpr:8(
NameExpr(func [__main__.func])
Args())))
Actual:
MypyFile:1(
ImportFrom:1(typing, [Final, Any])
FuncDef:3(
...
NameExpr(True [builtins.True])
Literal[True]?)
AssignmentStmt:8(
NameExpr(n* [__main__.n]) (diff)
CallExpr:8(
NameExpr(func [__main__.func])
Args())))
Alignment of first line difference:
E: NameExpr(n* [__main__.n] = None)
A: NameExpr(n* [__main__.n])
^
Update the test output using --update-data (implies -n0; you can additionally use the -k selector to update only specific tests)
=========================== short test summary info ============================
FAILED mypy/test/testsemanal.py::SemAnalSuite::semanal-basic.test::testFinalValuesOnVar
FAILED mypy/test/testtransform.py::TransformSuite::semanal-basic.test::testFinalValuesOnVar
===== 2 failed, 12827 passed, 366 skipped, 13 xfailed in 421.79s (0:07:01) =====
|
Sorry, something went wrong.
ilevkivskyi
approved these changes
Sep 25, 2025
ilevkivskyi
reviewed
Sep 25, 2025
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Oh, please update the tests output.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
done
…On Thu, Sep 25, 2025 at 12:32 PM Ivan Levkivskyi ***@***.***> wrote:
***@***.**** commented on this pull request.
Oh, please update the tests output.
—
Reply to this email directly, view it on GitHub
<#19859 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ3HIHT2VJVBLCWNR3UANBT3UQKI7AVCNFSM6AAAAACGTF2TOKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENRYGYYTGNJTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be honest I have no idea what this code does, but I know we need to fix it per advice from @hauntsaninja in #19846
(Explain how this PR changes mypy.)