Repository navigation
[mypyc] feat: extend get_expr_length for listcomp and genexp [4/4] - #19928
Draft
BobTheBuidler wants to merge 14 commits into
Draft
BobTheBuidler wants to merge 14 commits into
BobTheBuidler wants to merge 14 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BobTheBuidler
commented
Sep 26, 2025
Comment thread
mypyc/irbuild/for_helpers.py
Outdated
| and isinstance(expr.node, Var) | ||
| and expr.node.is_final | ||
| and isinstance(expr.node.final_value, str) | ||
| and expr.node.has_explicit_value |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I realized when looking that this line is unnecessary if the above checks pass
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
#19930 renders this irrelevant
Sorry, something went wrong.
BobTheBuidler
marked this pull request as ready for review
September 26, 2025 06:58
BobTheBuidler
commented
Sep 28, 2025
Comment thread
mypyc/test-data/irbuild-tuple.test
| r6 = r26 | ||
| goto L1 | ||
| L8: | ||
| r27 = var_object_size r0 |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This doesn't look right, should be 9
Sorry, something went wrong.
BobTheBuidler
marked this pull request as draft
September 28, 2025 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends get_expr_length to work with ListComprehension and GeneratorExpression.
All of the get_expr_length PRs are entirely independent and can be reviewed/merged in any order.