Repository navigation
[mypyc] feat: extend get_expr_length to work with RTuple and TupleType [2/4] - #19929
JukkaL merged 14 commits into
Conversation
Sorry, something went wrong.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
If we merge #19931 first, this PR will be reflected in a change to its IR test data |
Sorry, something went wrong.
| rtype = builder.node_type(expr) | ||
| if isinstance(rtype, RTuple): | ||
| return len(rtype.types) | ||
| proper_type = get_proper_type(builder.types[expr]) |
There was a problem hiding this comment.
Do we need this or will the check above it catch every case?
Sorry, something went wrong.
There was a problem hiding this comment.
This check is redundant. If this would be required for some unexpected reason, the issue should be fixed in node_type instead of here, since it would likely affect other things as well. Can you remove the second check?
Sorry, something went wrong.
There was a problem hiding this comment.
Removed
Sorry, something went wrong.
| r4 = box(int, r1) | ||
| r5 = box(int, r2) | ||
| r6 = box(int, r3) | ||
| r7 = PyTuple_Pack(3, r4, r5, r6) |
There was a problem hiding this comment.
Nice, the new IR is much more efficient!
Sorry, something went wrong.
This PR extends get_expr_length to work with type information from RTuple and TupleType classes
All of the get_expr_length PRs are entirely independent and can be reviewed/merged in any order.