FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Save work on emitting ignored diagnostics by hauntsaninja · Pull Request #20621 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Save work on emitting ignored diagnostics - #20621

Merged
hauntsaninja merged 4 commits into
python:masterfrom
hauntsaninja:skipdiag
Jan 26, 2026
ConversationCommits (4)ChecksFiles changed
Merged

Save work on emitting ignored diagnostics#20621
hauntsaninja merged 4 commits into
python:masterfrom
hauntsaninja:skipdiag

Conversation

hauntsaninja commented Jan 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

We already use this trick a little, but we can be much more aggressive about it.

Best reviewed with whitespace ignored. If the pure_ renames are undesirable it is easy to remove them, just helped me avoid some incorrect changes.

This is a 4.5% win on compiled self check

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
hauntsaninja marked this pull request as ready for review January 20, 2026 03:31

This comment has been minimized.

Sign in to view
ilevkivskyi approved these changes Jan 20, 2026
View reviewed changes

ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh wow, I tried something similar in summer, but didn't see big wins. I guess I simply needed to skip it in more places :-) About the renaming: not huge fan TBH I would prefer to rename those back.

JukkaL commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

@hauntsaninja Is something blocking the merge of this PR? I'd love to have the perf increase!

hauntsaninja commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator Author

No, just needed to undo the pure renames as per Ivan, doing that now...

github-actions Bot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja merged commit f875853 into python:master Jan 26, 2026
37 of 38 checks passed
hauntsaninja deleted the skipdiag branch January 26, 2026 21:26
hauntsaninja mentioned this pull request Jan 30, 2026
Merged
JukkaL pushed a commit that referenced this pull request Jan 30, 2026
Save work on emitting ignored diagnostics pt 2 (#20696)
195ab98 
This should be another 2.5% on self check

Sequel to #20621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL