FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Save work on emitting ignored diagnostics pt 2" by hauntsaninja · Pull Request #20716 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Revert "Save work on emitting ignored diagnostics pt 2" - #20716

Merged
hauntsaninja merged 1 commit into
masterfrom
revert-20696-perfcheck
Feb 3, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Revert "Save work on emitting ignored diagnostics pt 2"#20716
hauntsaninja merged 1 commit into
masterfrom
revert-20696-perfcheck

Conversation

hauntsaninja commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator

Reverts #20696

ilevkivskyi commented Feb 1, 2026

Copy link
Copy Markdown
Member

Just curious, did this cause some problems?

hauntsaninja commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator Author

Yes, the second PR did, see #20696 (comment)
I wasn't as careful as in the first PR

github-actions Bot commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

ilevkivskyi commented Feb 1, 2026

Copy link
Copy Markdown
Member

Hm, OK, I see. Maybe you can simply check if there any active error watchers (IIRC I already needed this for something, so I am quite this should be easy)? This should allow skipping a bunch more error-emitting code.

hauntsaninja commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator Author

Will do!

hauntsaninja commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Merging this for now to keep master usable, will follow up with the watcher change + better testing

hauntsaninja merged commit 21eb6a1 into master Feb 3, 2026
23 checks passed
hauntsaninja deleted the revert-20696-perfcheck branch February 3, 2026 04:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL