Fix regression for catching empty tuple in except - #21153
Conversation
Sorry, something went wrong.
This comment has been minimized.
|
@ilevkivskyi can you help me understand why are the parallel tests are failing on this one? |
Sorry, something went wrong.
|
I am already going to bed, didn't actually look, but judging from the test output, most likely this is a bug in ast-serialize (it is automatically used for parallel checking). |
Sorry, something went wrong.
|
Yeah, quickly looked at read_try_stmt() we don't set line/column for var_expr. |
Sorry, something went wrong.
This comment has been minimized.
| pass | ||
| [builtins fixtures/tuple.pyi] | ||
|
|
||
| [case testExceptWithMultipleTypes6_no_parallel] |
There was a problem hiding this comment.
Could you please open an issue in ast_serialize tracker about this, and leave a comment above why this is skipped?
Sorry, something went wrong.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
##### [\`v1.20.1\`](https://github.com/python/mypy/blob/HEAD/CHANGELOG.md#Mypy-1201) - Always disable sync in SQLite cache (Ivan Levkivskyi, PR [21184](python/mypy#21184)) - Temporarily skip few base64 tests (Ivan Levkivskyi, PR [21193](python/mypy#21193)) - Revert `dict.__or__` typeshed change (Ivan Levkivskyi, PR [21186](python/mypy#21186)) - Fix narrowing for match case with variadic tuples (Shantanu, PR [21192](python/mypy#21192)) - Avoid narrowing `type[T]` in type calls (Shantanu, PR [21174](python/mypy#21174)) - Fix regression for catching empty tuple in except (Shantanu, PR [21153](python/mypy#21153)) - Fix reachability for frozenset and dict view narrowing (Shantanu, PR [21151](python/mypy#21151)) - Fix narrowing with chained comparison (Shantanu, PR [21150](python/mypy#21150)) - Avoid narrowing to unreachable at module level (Shantanu, PR [21144](python/mypy#21144)) - Allow dangerous identity comparisons to `Any` typed variables (Shantanu, PR [21142](python/mypy#21142)) - `--warn-unused-config` should not be a strict flag (Ivan Levkivskyi, PR [21139](python/mypy#21139)) ##### [\`v1.20.0\`](python/mypy@v1.19.1...v1.20.0) Renovate-Branch: renovate/r2026-mypy-1.x Change-Id: I88dbcfe5e6938c1401f9ffdda71a9a5e9703324a Priv-Id: ac1477044856e83cc49e7b2b61d5068c572e0b50
Fixes #21152