| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualityit looks like with this change the __del__ method of an interpreted base class is skipped, for example in this test case:
[case testInheritedHeapBaseFinalizerRuns] from mypy_extensions import mypyc_attr events: list[str] = [] @mypyc_attr(native_class=False) class HeapError(Exception): def __del__(self) -> None: events.append("base del") class NativeError(HeapError): def __init__(self, payload: object) -> None: self.own = payload [file driver.py] import gc from native import NativeError, events for _ in range(1): NativeError(object()) gc.collect() assert events == ["base del"], eventsi think we're missing a call to PyObject_CallFinalizerFromDealloc in generate_dealloc_for_class in the case for classes with builtin_base.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityGood catch, included this test as well, thank you!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.