Repository navigation
Support a small amount of generic converters for attrs - #22206
Open
A5rocks wants to merge 1 commit into
Open
A5rocks wants to merge 1 commit into
A5rocks wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core)
+ homeassistant/helpers/device_registry.py:1042: error: Unused "type: ignore" comment [unused-ignore]
+ homeassistant/helpers/device_registry.py:2187: error: Unused "type: ignore" comment [unused-ignore]
+ homeassistant/helpers/device_registry.py:4429: error: Unused "type: ignore" comment [unused-ignore]
scipy-stubs (https://github.com/scipy/scipy-stubs)
- tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@JukkaL what do you think of this approach? (TBH I don't know which operations are safe or not) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #8625.
To be honest I don't see why we can't recurse on the converter return type along with the attribute type, and then set all the typevars we see based on the relevant part of the attribute type. I didn't do that since I don't know the right visitor to do so, but presumably I'm missing something that makes this harder?