Repository navigation
Return boolean literals directly from truthiness helpers - #22255
Merged
hauntsaninja merged 1 commit intoOct 21, 2026
Merged
hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Teach true_only and false_only to produce the single possible boolean literal directly, just as false_only already does for empty strings and integer zero. Truthiness checks and boolean operators can then stop expanding bool into a union before asking these helpers to restrict it. Authored by Codex
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach true_only and false_only to produce the single possible boolean literal directly, just as false_only already does for empty strings and integer zero.
Truthiness checks and boolean operators can then stop expanding bool into a union before asking these helpers to restrict it.
Authored by Codex