FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow Void typed values as returns from None functions by TRManderson · Pull Request #2829 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Allow Void typed values as returns from None functions - #2829

Closed
TRManderson wants to merge 5 commits into
python:masterfrom
TRManderson:#2828
ConversationCommits (5)ChecksFiles changed
Closed

Allow Void typed values as returns from None functions#2829
TRManderson wants to merge 5 commits into
python:masterfrom
TRManderson:#2828

Conversation

TRManderson commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

Fixes #2828

TRManderson commented Feb 8, 2017

Copy link
Copy Markdown
Contributor Author

The test failing is one that explicitly tests that there is an error when attempting this :/

TRManderson mentioned this pull request Feb 8, 2017
Closed
JukkaL requested changes Mar 6, 2017
View reviewed changes
Comment thread test-data/unit/check-statements.test
def f() -> None:
return None
def g() -> None:
return f() # E: No return value expected

JukkaL Mar 6, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you keep the test case, but just remove the error message? I.e. it would test that this no longer generates an error message.

TRManderson Mar 7, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

ilevkivskyi commented Mar 14, 2017

Copy link
Copy Markdown
Member

This PR looks good to me. It is still marked with Changes requested although changes has ben already made.

ddfisher commented Mar 19, 2017

Copy link
Copy Markdown
Collaborator

This has been superseded by a more complete fix in #3024. Thanks for looking into this!

ddfisher closed this Mar 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JukkaL JukkaL requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL