Repository navigation
Skip rest of file upon top-level always-false assert - #5894
Merged
gvanrossum merged 5 commits intoNov 15, 2018
Merged
gvanrossum merged 5 commits into
gvanrossum merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
added 3 commits
November 14, 2018 15:10
- A top-level assert has no indentation. - An always-false condition is a check for sys.platform or sys.version_info or a condition derived from MYPY or from a name passed to --always-false; `assert False` doesn't count (!). Fixes python#5308
JukkaL
reviewed
Nov 14, 2018
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good, just a few minor comments.
Sorry, something went wrong.
Comment thread
docs/source/common_issues.rst
Outdated
| # Other systems | ||
|
|
||
| As a special case, you can also use one of these checks in a top-level | ||
| ``assert``; this makes mypy skip the rest of the file. Example: |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Maybe explicitly mention that the assert must be unconditional and not nested within a statement.
Sorry, something went wrong.
Comment thread
test-data/unit/check-unreachable-code.test
| return 3 | ||
| [builtins fixtures/isinstance.pyi] | ||
|
|
||
| [case testUnreachableAfterToplevelAssert] |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Maybe also test the case where the assert is nested within an if statement.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
OK, updated doc and added test. |
Sorry, something went wrong.
JukkaL
approved these changes
Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A top-level assert has no indentation.
An always-false condition is a check for sys.platform or
sys.version_info or a condition derived from MYPY or from a name
passed to --always-false; assert False doesn't count (!).
(This definition is the same used to exclude conditional imports.)
Fixes #5308.