Repository navigation
Produce mypyc errors when encountering bug #5423 - #7482
Merged
msullivan merged 1 commit intoSep 9, 2019
Merged
msullivan merged 1 commit into
msullivan merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Currently when we encounter #5423 (when someting is incorrectly inferred as None), we generate code that casts a variable to None incorrectly since we are confused about the real type. Now produce an error message saying to add an annotation when we detect it. Fix up the places in mypy this caused errors.
msullivan
force-pushed
the
error-none-var
branch
from
36b2dde to
6e05ce1
Compare
September 7, 2019 01:48
ilevkivskyi
approved these changes
Sep 9, 2019
ilevkivskyi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Also thanks for the clean-up!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we encounter #5423 (when someting is incorrectly
inferred as None), we generate code that casts a variable to None
incorrectly since we are confused about the real type.
Now produce an error message saying to add an annotation when we
detect it.
Fix up the places in mypy this caused errors.