FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add __path__ to package __init__ by hauntsaninja · Pull Request #9454 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Add __path__ to package __init__ - #9454

Merged
hauntsaninja merged 8 commits into
python:masterfrom
hauntsaninja:path
Aug 4, 2021
ConversationCommits (8)ChecksFiles changed
Merged

Add __path__ to package __init__#9454
hauntsaninja merged 8 commits into
python:masterfrom
hauntsaninja:path

Conversation

hauntsaninja commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator

Resolves #1422

I see there's a small graveyard of attempted fixes to this issue. Hopefully the same fate does not befall this PR.

hauntsaninja marked this pull request as draft September 18, 2020 05:39

hauntsaninja commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator Author

I wasn't thrilled about the 200+ failed tests, so I added list to lib-stub's builtins. I guess I'm about to find out if that's acceptable :-)

hauntsaninja marked this pull request as ready for review September 18, 2020 18:41
JelleZijlstra reviewed Sep 21, 2020
View reviewed changes
Comment thread test-data/unit/check-incomplete-fixture.test
m.x # E: "object" has no attribute "x"
[file m.py]

[case testListMissingFromStubs]

JelleZijlstra Sep 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why did you delete this test? The behavior it's testing (error messages tailored to bad fixtures) seems useful.

hauntsaninja Sep 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The quickest way to resolve the many test failures was to add list to the builtin stubs (I expect this might be controversial), which of course broke this test.
We have tests for tailored error messages for several other specific fixtures, so I figured this wouldn't be the worst test to remove, especially since I anticipate pushback on adding list to builtin stubs.

hauntsaninja added 4 commits October 5, 2020 22:05

mfarrugi commented Dec 9, 2020

Copy link
Copy Markdown

@JelleZijlstra what else needs to be done here? This fixes the first mypy bug many users will run into.

JelleZijlstra commented Dec 9, 2020

Copy link
Copy Markdown
Member

I'd prefer for @JukkaL to review it.

JukkaL commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator

The build seems to be stuck. If you can make this up to date with master so that there's a passing build, I'm happy to review this.

hauntsaninja reopened this Dec 11, 2020

hauntsaninja commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator Author

Unstuck Travis, and all is green!

hauntsaninja mentioned this pull request Dec 13, 2020
Closed

pearceeverydaylabs commented Mar 19, 2021

Copy link
Copy Markdown

@JukkaL @hauntsaninja looks like we were really close on this! Any chance we revisit and get it merged? 🤞

pearceeverydaylabs commented Apr 2, 2021

Copy link
Copy Markdown

@JukkaL @hauntsaninja bump for approval :)

This comment has been minimized.

Sign in to view
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request Apr 15, 2021
[pkgutil] returns a List[str] usually
34f604b 
Yes, technically it returns whatever its first argument is if it isn't
a list.

Doing this because python/mypy#9454 (comment)
hauntsaninja mentioned this pull request Apr 15, 2021
Merged
hauntsaninja mentioned this pull request Apr 15, 2021
Closed

This comment has been minimized.

Sign in to view

JelleZijlstra commented Apr 15, 2021

Copy link
Copy Markdown
Member

Python 3.5 CI failed with some SSL error (as seems to happen half the time now). I restarted it.

hauntsaninja added a commit to python/typeshed that referenced this pull request Apr 15, 2021
pkgutil: returns a List[str] usually (#5222)
3d8bffa 
Yes, technically it returns whatever its first argument is if it isn't
a list.

Doing this because python/mypy#9454 (comment)

github-actions Bot commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

porcupine (https://github.com/Akuli/porcupine.git)
+ porcupine/images/__init__.py:9: error: Name "__path__" already defined (possibly by an import)  [no-redef]
+ porcupine/plugins/__init__.py:13: error: Name "__path__" already defined (possibly by an import)  [no-redef]

poetry (https://github.com/python-poetry/poetry.git)
- poetry/__init__.py:4: error: Cannot determine type of "__path__"
+ poetry/mixology/failure.py:144: error: Item "RootCause" of "Union[RootCause, NoVersionsCause, DependencyCause, ConflictCause, PythonCause, PlatformCause, PackageNotFoundCause]" has no attribute "conflict"

edgedb (https://github.com/edgedb/edgedb.git)
+ edb/schema/std.py:41: error: unused "type: ignore" comment
+ edb/schema/std.py:42: error: unused "type: ignore" comment
+ edb/schema/std.py:43: error: unused "type: ignore" comment
+ edb/schema/std.py:44: error: unused "type: ignore" comment

hauntsaninja merged commit 18ff207 into python:master Aug 4, 2021
hauntsaninja deleted the path branch August 4, 2021 08:44
This was referenced Dec 16, 2021
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support __path__ in packages

5 participants

Back | FazBrowse Home | New Git URL