FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Exclude `.codespell` from Sphinx by AA-Turner · Pull Request #2264 · python/peps · GitHub

Repository navigation

Exclude .codespell from Sphinx - #2264

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
AA-Turner:fix-ci-codeowners
Jan 24, 2022
Merged

JelleZijlstra merged 1 commit into
python:mainfrom
AA-Turner:fix-ci-codeowners

Conversation

AA-Turner commented Jan 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

RE #2151; fixes Sphinx build.

A

CAM-Gerlach changed the title Exclude .codeowners from Sphinx Exclude .codespell from Sphinx Jan 24, 2022
JelleZijlstra merged commit 94b32ce into python:main Jan 24, 2022

Copy link
Copy Markdown
Member Author

Good god I'm bad on getting things mixed up in PR titles -- first RST vs RFC, now codeowners vs codespell 😁

Thanks for merging Jelle

CAM-Gerlach commented Jan 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Happens to all of us 😆 Luckily I fixed it with a few seconds to spare :)

This is going to keep happening whenever anyone add .txt files to the repo, whether as config or as a PEP supplement. Is there any way we can specifically match only \.rst$|^/pep-[0-9]{4}\.txt$, or at least only .txt (but not .rst) in the root?

AA-Turner commented Jan 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ideally I'd whitelist to include_patterns = ["pep-????"], but Sphinx doesn't support include_patterns. (Need to get a second to submit a feature request & implementation upstream)

The build on PRs going forwards will make it much easier to catch in the future, though.

A

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL