PEP 1: Further clarify PEP-Delegate notification & acceptance process - #2273
JelleZijlstra merged 2 commits into
Conversation
Sorry, something went wrong.
AA-Turner
left a comment
There was a problem hiding this comment.
I think this is helpful in making the process more explicit, and being more instructive for authors and potential sponsors.
Some suggestions (and the one when I clicked the wrong button when trying to start the review)
A
Sorry, something went wrong.
| The Steering Council will generally accept such self-nominations by default, | ||
| but may choose to decline them. |
There was a problem hiding this comment.
| The Steering Council will generally accept such self-nominations by default, | |
| but may choose to decline them. | |
| The Steering Council will ordinarily approve such self-nominations, | |
| but may choose to decline them. |
If "ordinarily" is too formal, "usually" also works.
"approve" makes more explicit that you must hear back in the affirmative from the Council.
A
Sorry, something went wrong.
There was a problem hiding this comment.
I see what you're trying to do here, but I'm concerned it is getting a bit far away from the original intended meaning—it now implies that the SC will typically approve nominations, but no longer directly mentions the decision-making rationale of approve-by-default, the original purpose of this sentence. It is now making a statement on approval probabilty (offers will be ordinarily approved) rather than approval strategy (offers will be approved by default unless there is a significant reason not to do so), as "ordinarily" (and "usually") refers to frequency while "generally" more generically is a general hedge, while "accept [...] by default" was what "generally" was referencing, not "accept" alone.
A more conservative suggestion that keeps the original meaning but applies your "approve" change would be the following:
| The Steering Council will generally accept such self-nominations by default, | |
| but may choose to decline them. | |
| The Steering Council will generally approve such self-nominations by default, | |
| but may choose to decline them. |
Sorry, something went wrong.
There was a problem hiding this comment.
Also, @brettcannon, thoughts?
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for the added rationale -- the "generally" and "by default" felt odd in the same sentence, but I see they are serving different purposes.
Sorry, something went wrong.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
AA-Turner
left a comment
There was a problem hiding this comment.
Substantive changes look good
Sorry, something went wrong.
|
Hey @brettcannon , is there any objection to going ahead with this? Or should we ask for another formal round of SC review here? |
Sorry, something went wrong.
|
Nope, go ahead and merge it! |
Sorry, something went wrong.
Followup to #1430 and PRs #2256 and #2257 , and discussed on python/steering-council#97 , to ensure the description of how PEP delegates should notify and request approval of the Steering Council is clear and consistent, and matches actual established practice, based on the descrepencies with the current merged language identified by @AA-Turner and discussed further with @willingc .