FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 670: clarify cast; don't change return type by vstinner · Pull Request #2349 · python/peps · GitHub

  1. python
  2. peps

Repository navigation

PEP 670: clarify cast; don't change return type - #2349

Merged
vstinner merged 6 commits into
python:mainfrom
vstinner:pep670_cast
Feb 22, 2022
ConversationCommits (6)ChecksFiles changed
Merged

PEP 670: clarify cast; don't change return type#2349
vstinner merged 6 commits into
python:mainfrom
vstinner:pep670_cast

Conversation

vstinner commented Feb 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member
  • Clarify how arguments are cast
  • Limited C API 3.11 no longer cast arguments
  • No longer remove return value
  • Require to not change the return type
  • Don't change macros having multiple return types

PEP 670: clarify cast; don't change return type
9a22e13 
* Clarify how arguments are cast
* Limited C API 3.11 no longer cast arguments
* No longer remove return value
* Require to not change the return type
* Don't change macros having multiple return types

vstinner commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

I updated PEP 670 to take in account @encukou and @gpshead feedback on python-dev and on my python/cpython#31221 review.

@encukou @gpshead @erlend-aasland: Would you mind to have a look?

vstinner commented Feb 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

You can read the formatted PEP by clicking in the Files Changes tab on the 3 middle dots (...) menu at the pep-0670.rst line: in this menu, click on "View file".

Current link: pep-0670.rst.

CAM-Gerlach requested changes Feb 21, 2022
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixes for a number of grammar errors in the added/changed text, as well as a few PEP 12 issues and for correct code block syntax highlighting. All the changes are as suggestions, and can be applied cleanly together by simply going to the Files tab, clicking the Add to batch button on each change, and then clicking the Commit button, which will avoid the all problems we both experienced last time. Alternatively, I'm happy to do it for you. Either way, don't forget to pull your branch after doing so. Thanks!

Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst
* ``_Py_atomic_store_64bit()``
* ``asdl_seq_SET()``
* ``asdl_seq_SET_UNTYPED()``
For example, Python 3.7 changed ``PyUnicode_AsUTF8()`` return type from

CAM-Gerlach Feb 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
For example, Python 3.7 changed ``PyUnicode_AsUTF8()`` return type from
For example, Python 3.7 changed ``PyUnicode_AsUTF8()``\ 's return type from

Fix grammar error

CAM-Gerlach Feb 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This grammar error wasn't fixed

Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
Comment thread pep-0670.rst Outdated
erlend-aasland approved these changes Feb 22, 2022
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine with this, Victor.

vstinner commented Feb 22, 2022

Copy link
Copy Markdown
Member Author

@CAM-Gerlach: I addressed most of your reviews, thanks.

vstinner merged commit 42e921e into python:main Feb 22, 2022
vstinner deleted the pep670_cast branch February 22, 2022 12:17

vstinner commented Feb 22, 2022

Copy link
Copy Markdown
Member Author

Follow-up: I wrote an email to python-dev: https://mail.python.org/archives/list/python-dev@python.org/thread/VM6I3UHVMME6QRSUOYLK6N2OZHP454W6/

CAM-Gerlach commented Feb 22, 2022 •
edited by AA-Turner
Loading

Copy link
Copy Markdown
Member

Good call on using the language:: c directive in lieu of .. code-block:: c on all the code blocks, but it looks like at least a few of the grammar errors cited were not fixed (FYI, you can edit them, e.g. to remove the code-block directive, and apply those instead, to avoid them getting missed in the future). If I do get the chance to do a full copyedit of the PEP (I've been busy with other PEP editor stuff, sorry), I'll clean those up.

erlend-aasland mentioned this pull request May 13, 2022
Closed
erlend-aasland mentioned this pull request Jun 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach requested changes
erlend-aasland erlend-aasland approved these changes
encukou Awaiting requested review from encukou
gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL